chimney-protobuf: To have a (default?) configuration setting allowing to skip manual assign for UnknownFieldSet #506
codesurf42
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
In general - yes it would be convenient. Problem is that:
We have #408 created for that reason, but so far whenever there was some time for development, there were more important things to fix (mostly because some things needs to be cleaned up before committing to 1.0.0 and semver, since they break bincompat, and some can be fixed later without breaking changes). |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Chimney is getting better with full ADT conversions 🚀 . One small issue when using it with Protobuf is https://chimney.readthedocs.io/en/stable/cookbook/#unknownfieldset While switching this setting off simplify chimney conversions and chances of getting false-positive conversions with default values, unknown fields seem to be the default in proto and to stay there for a long time (https://protobuf.dev/programming-guides/proto3/#unknowns, off and on rollback in proto3) and in many projects changing these default proto settings may not be the best way to go.
While someone can just add a manual conversion with
.withFieldConst(_.unknownFields, UnknownFieldSet())
(and similar for ADTs), maybe an easier, "out of the box" way would be to have such default conversion in place when also usingchimney-protobuf
module?Beta Was this translation helpful? Give feedback.
All reactions