From 29c783a2787bafae8201eb6ab2811983bd923641 Mon Sep 17 00:00:00 2001
From: Tomasz Godzik <tgodzik@virtuslab.com>
Date: Wed, 20 Nov 2024 20:21:52 +0100
Subject: [PATCH] bugfix: Don't set empty edits

It seems that the command will not be invoked in such editors such as Zed in this case

Fixes https://github.com/scalameta/metals/issues/6949
---
 .../metals/codeactions/CodeActionBuilder.scala      | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/metals/src/main/scala/scala/meta/internal/metals/codeactions/CodeActionBuilder.scala b/metals/src/main/scala/scala/meta/internal/metals/codeactions/CodeActionBuilder.scala
index b6967779d51..05286cc1733 100644
--- a/metals/src/main/scala/scala/meta/internal/metals/codeactions/CodeActionBuilder.scala
+++ b/metals/src/main/scala/scala/meta/internal/metals/codeactions/CodeActionBuilder.scala
@@ -27,8 +27,9 @@ object CodeActionBuilder {
       "Only changes or documentChanges can be set in code action at the same time",
     )
 
-    val workspaceEdits = new l.WorkspaceEdit()
-    if (changes.nonEmpty)
+    // we don't want to set edit to make it resolve lazily in codeAction/resolve
+    if (changes.nonEmpty) {
+      val workspaceEdits = new l.WorkspaceEdit()
       workspaceEdits.setChanges(
         changes
           .map { case (path, edits) =>
@@ -37,10 +38,12 @@ object CodeActionBuilder {
           .toMap
           .asJava
       )
-    else if (documentChanges.nonEmpty)
+      codeAction.setEdit(workspaceEdits)
+    } else if (documentChanges.nonEmpty) {
+      val workspaceEdits = new l.WorkspaceEdit()
       workspaceEdits.setDocumentChanges(documentChanges.map(_.asJava).asJava)
-
-    codeAction.setEdit(workspaceEdits)
+      codeAction.setEdit(workspaceEdits)
+    }
     command.foreach(codeAction.setCommand)
     disabledReason.foreach(reason =>
       codeAction.setDisabled(new l.CodeActionDisabled(reason))