improvement: trim hover body (#5694)

scalameta · Oct 4, 2023 · 664dcce · 664dcce
1 parent dfa965e
commit 664dcce
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/mtags-shared/src/main/scala/scala/meta/internal/pc/HoverMarkup.scala b/mtags-shared/src/main/scala/scala/meta/internal/pc/HoverMarkup.scala
@@ -2,6 +2,10 @@ package scala.meta.internal.pc
 
 object HoverMarkup {
 
+  // VSCode trims the message to ~100000, thus messing the markdown for very long messages.
+  // Number based on experiments from 29.09.2023.
+  private val MaxHoverBodyLength = 50000
+
   /**
    * Render the textDocument/hover result into markdown.
    *
@@ -42,15 +46,19 @@ object HoverMarkup {
     markdown.toString()
   }
 
+  private def trimBody(body: String) =
+    if (body.length() <= MaxHoverBodyLength) body
+    else body.take(MaxHoverBodyLength) + "..."
+
   def apply(body: String): String = {
     s"""|```scala
-        |$body
+        |${trimBody(body)}
         |```""".stripMargin
   }
 
   def javaHoverMarkup(body: String): String = {
     s"""|```java
-        |$body
+        |${trimBody(body)}
         |```""".stripMargin
   }