Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go to refs does not work for local symbols for 3.4.x #6653

Closed
kasiaMarek opened this issue Aug 2, 2024 · 0 comments · Fixed by #6654
Closed

Go to refs does not work for local symbols for 3.4.x #6653

kasiaMarek opened this issue Aug 2, 2024 · 0 comments · Fixed by #6654
Assignees
@kasiaMarek
Labels
bug Something that is making a piece of functionality unusable navigation Related to goto definition, find references, open symbol
Milestone
Metals v1.4.0

Comments

@kasiaMarek
Copy link
Contributor

Describe the bug

Find references/go to references does not work for Scala 3.4.x.

This is connected to changes in: #5940. Now we use pc for local symbols, where pc for 3.4.x doesn't support finding references.

Expected behavior

Go to refs should work using semanticdb in this case.

Operating system

macOS

Editor/Extension

VS Code

Version of Metals

v.1.3.4

Extra context or search terms

No response
@tgodzik tgodzik added bug Something that is making a piece of functionality unusable navigation Related to goto definition, find references, open symbol labels Aug 5, 2024
@kasiaMarek kasiaMarek mentioned this issue Aug 6, 2024
Merged
@kasiaMarek kasiaMarek self-assigned this Aug 6, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Metals Issue Board Aug 8, 2024
@tgodzik tgodzik added this to the Metals v1.4.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasiaMarek kasiaMarek

Labels
bug Something that is making a piece of functionality unusable navigation Related to goto definition, find references, open symbol
Projects
Metals Issue Board
Archived in project
Milestone
Metals v1.4.0
Development

Successfully merging a pull request may close this issue.

fix: use semanticdb also for local and when stale if scala version do… kasiaMarek/metals
2 participants
@tgodzik @kasiaMarek