improvement: queue or cancel previous connect request #6691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
cancel-build-server-connection
branch
4 times, most recently
from
b1564af to
3f2a29b
Compare
kasiaMarek
commented
Aug 20, 2024
| @@ -211,18 +212,12 @@ class SbtBloopLspSuite | |||
| _ = assertNoDiff( | |||
| client.beginProgressMessages, | |||
| List( | |||
| progressMessage, | |||
There was a problem hiding this comment.
We don't deduplicate like this anymore. Instead requests will be queued and the first one will get cancelled. So sbt bloopInstall will be executed twice, and the first request will be cancelled after that, so import and indexing are executed only once.
tgodzik
reviewed
Sep 17, 2024
| val iter = queue.iterator() | ||
| while (iter.hasNext()) { | ||
| val curr = iter.next() | ||
| request.cancelCompare(iter.next().request) match { |
There was a problem hiding this comment.
Could you explain the logic a bit better here? Could we use some case objects instead of just numbers?
tgodzik
requested changes
Sep 17, 2024
|
|
||
| class Interruptable[+T] private ( | ||
| futureIn: Future[T], | ||
| cancelPromise: Promise[Unit], |
There was a problem hiding this comment.
Are we able to forward the cancel request to an underlying process if for example bloopInstall is running?
kasiaMarek
force-pushed
the
cancel-build-server-connection
branch
from
3f2a29b to
044cc69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.