Refactor operations and their builders #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
commented
Nov 7, 2024
| @@ -18,6 +19,16 @@ | |||
| @NotThreadSafe | |||
| public class Delete extends Mutation { | |||
|
|
|||
| Delete( | |||
There was a problem hiding this comment.
Added constructors to set all parameters for operations.
| } | ||
|
|
||
| return delete; | ||
| return new Delete( |
There was a problem hiding this comment.
Use the added constructors in operation builders.
| private final Optional<Key> clusteringKey; | ||
| private Optional<String> namespace; | ||
| private Optional<String> tableName; | ||
| @Nullable private final Key clusteringKey; | ||
| @Nullable private String namespace; | ||
| private String tableName; |
There was a problem hiding this comment.
Stopped using Optional in operations.
brfrn169
force-pushed
the
refactor-operations-and-builders
branch
3 times, most recently
from
40576ee
to
4045728
Compare
brfrn169
force-pushed
the
refactor-operations-and-builders
branch
from
4045728
to
adb8fa7
Compare
komamitsu
reviewed
Nov 11, 2024
| @@ -1221,13 +1207,15 @@ public BuildableScanFromExistingWithOngoingWhereOr whereOr( | |||
| public BuildableScanOrScanAllFromExisting clearStart() { | |||
| checkNotScanWithIndexOrScanAll(); | |||
| this.startClusteringKey = null; | |||
| this.startInclusive = false; | |||
There was a problem hiding this comment.
This could be a (very minor) compatibility issue for those who expect this method to keep the inclusion setting? I think this is a reasonable bugfix, though.
There was a problem hiding this comment.
Strictly speaking, it could be. But we basically don't use startInclusive if startClusteringKey is null, so this shouldn't cause any issues actually. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors operations (Get, Scan, Put, Insert, Upsert, Update, and Delete) and their builders.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A