Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete behavior in Cosmos adapter #2341

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

brfrn169
Copy link
Collaborator

Description

This PR fixes the delete behavior in the Cosmos adapter. Currently, if we attempt to delete a non-existent record, the Cosmos adapter throws an ExecutionException. This behavior is inconsistent with other adapters. This PR adjusts it to ensure consistent behavior across adapters.

Related issues and/or PRs

N/A

Changes made

  • Stop throwing an exception when attempting to delete a non-existent record in the Cosmos adapter.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Fixed the behavior when deleting a non-existing record in the Cosmos adapter.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brfrn169 brfrn169 merged commit cee15f3 into master Nov 18, 2024
48 checks passed
@brfrn169 brfrn169 deleted the fix-delete-behavior-in-cosmos branch November 18, 2024 03:30
feeblefakie pushed a commit that referenced this pull request Nov 18, 2024
feeblefakie pushed a commit that referenced this pull request Nov 18, 2024
feeblefakie pushed a commit that referenced this pull request Nov 18, 2024
feeblefakie pushed a commit that referenced this pull request Nov 18, 2024
feeblefakie pushed a commit that referenced this pull request Nov 18, 2024
feeblefakie pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants