Merge pull request #6 from RoboLV/patch-1

Remove unused attribute optins values

Author: alfredsgenkins

src/Model/Resolver/Products/DataPostProcessor/Attributes.php

@@ -128,7 +128,6 @@ protected function appendWithValue(
 
                 if (!$attributeValue) {
                     // Remove all empty attributes
-//                    unset($productAttributes[$productId][$attributeCode]);
                     continue;
                 }
 
@@ -140,6 +139,7 @@ protected function appendWithValue(
 
     /**
      * Append options to attribute options
+     *
      * @param $attributes ProductAttributeInterface[]
      * @param $products ExtensibleDataInterface[]
      * @param $productAttributes array
@@ -150,7 +150,7 @@ protected function appendWithOptions(
         array $products,
         array $swatchAttributes,
         array &$productAttributes
-    ) {
+    ): void {
         $attributeCodes = array_keys($attributes);
         $searchCriteria = $this->searchCriteriaBuilder
             ->addFilter('main_table.attribute_code', $attributeCodes, 'in')
@@ -168,17 +168,60 @@ protected function appendWithOptions(
         foreach ($products as $product) {
             $id = $product->getId();
 
+            $configuration = $product->getTypeId() === 'configurable'
+                ? $product->getTypeInstance()->getConfigurableOptions($product)
+                : [];
+
             foreach ($detailedAttributes as $attribute) {
                 $key = $attribute->getAttributeCode();
+
+                if (!isset($productAttributes[$id][$key])) {
+                    continue;
+                }
+
+                $productAttributes[$id][$key]['attribute_options'] = [];
+                $variantAttributeValues = [];
+
+                if ($product->getTypeId() === 'configurable') {
+                    $attributeId = $attribute->getAttributeId();
+                    $productAttributeVariants = $configuration[$attributeId] ?? [];
+
+                    $variantAttributeValues = array_filter(
+                        array_column($productAttributeVariants, 'value_index')
+                    );
+                }
+
+                if (
+                    !isset($productAttributes[$id][$key]['attribute_value'])
+                    && !count($variantAttributeValues)
+                ) {
+                    continue;
+                }
+
+                // Merge all attribute values into one array(map) and flip values with keys (convert to hash map)
+                // This used to bring faster access check for value existence
+                // Hash key variable check is faster then traditional search
+                $values = array_flip( // Flip Array
+                    array_merge( // phpcs:ignore
+                        array_filter( // explode might return array with empty value, remove such values
+                            explode(',', $productAttributes[$id][$key]['attribute_value'] ?? '')
+                        ),
+                        $variantAttributeValues
+                    )
+                );
+
                 $options = $attribute->getOptions();
                 array_shift($options);
-
                 $productAttributes[$id][$key]['attribute_options'] = [];
 
                 foreach ($options as $option) {
                     $value = $option->getValue();
-                    $optionIds[] = $value;
 
+                    if (!isset($values[$value])) {
+                        continue;
+                    }
+
+                    $optionIds[] = $value;
                     $productAttributes[$id][$key]['attribute_options'][$value] = [
                         'value' => $value,
                         'label' => $option->getLabel()