Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on logger errors/fatal #5

Open
noahgibbs opened this issue Nov 14, 2023 · 0 comments
Open

Fail on logger errors/fatal #5

noahgibbs opened this issue Nov 14, 2023 · 0 comments

Comments

@noahgibbs
Copy link
Collaborator

noahgibbs commented Nov 14, 2023

I've fixed the "error when running app code doesn't fail the test" problem on a branch, so it should be merged along with skip/error results for tests. However, right now you can have errors in the logger and the test can't even see those, let alone fail on them. That should change. (Also certain console.logs in Scarpe-Wasm)

Maybe log data should be passed through in the metadata field of the Minitest export? Something like that.

@noahgibbs noahgibbs changed the title Detect errors more reliably Fail on logger errors/fatal Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant