Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Searcher for script templates #1

Closed
imagejan opened this issue Dec 22, 2017 · 3 comments · Fixed by #13
Closed

Provide a Searcher for script templates #1

imagejan opened this issue Dec 22, 2017 · 3 comments · Fixed by #13

Comments

@imagejan
Copy link
Member

In addition to snippets, it might be useful to be able to search all available script templates and open them in the script editor.

See also scijava/script-editor#6.

@imagejan
Copy link
Member Author

imagejan commented Feb 6, 2018

I've made a first attempt implementing this on the add-template-search branch.

Remaining tasks:

  • Open the script when the Open button is pressed. (@ctrueden what's the preferred way of doing so using a SciJava service? We should keep it agnostic of the script-editor component, no?)

On the other hand, maybe this whole search module should actually live in the script-editor repo? Opinions, @ctrueden, @stelfrich?

@stelfrich
Copy link
Member

On the other hand, maybe this whole search module should actually live in the script-editor repo?

That's a philosophical question, I guess. Templates, in general, are independent of the script-editor component. If script-editor is not available, there's not really that much you can do with the search result, right? However, you should still be able to get template search results, even if you can't take any action on them in the previous case.

What about keeping TemplateSearchResult and TemplateSearcher in here and moving OpenTemplateSearchActionFactory to script-editor? We don't have an example for that kind of separation at the moment, but generating search results and providing an action could be separated.

@imagejan
Copy link
Member Author

imagejan commented Mar 2, 2018

Thanks, @stelfrich, for the advice. I wasn't aware that the "Source" and "Help" SearchActionFactory classes already live in imagej-legacy.

I now moved OpenTemplateSearchActionFactory to imagej-legacy in imagej/imagej-legacy#181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants