Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge dependency on script-editor #2

Open
ctrueden opened this issue Jul 6, 2023 · 2 comments
Open

Purge dependency on script-editor #2

ctrueden opened this issue Jul 6, 2023 · 2 comments

Comments

@ctrueden
Copy link
Member

ctrueden commented Jul 6, 2023

This component has a dependency on org.scijava:script-editor so that it can implement a PythonScriptSyntaxHighlighter. But this drags in several other dependencies including scijava-ui-swing, which is undesirable. The syntax highlighting layer should probably be its own layer. We need to scrutinize the modularity of the script-editor component to improve the architecture here.

@karlduderstadt
Copy link
Collaborator

karlduderstadt commented Jul 7, 2023

Yes, I remember worrying about this and trying to think of an alternative approach. One quick fix could be to move PythonScriptSyntaxHighlighter to the highlighters package in the script-editor. https://github.com/scijava/script-editor/tree/master/src/main/java/org/scijava/ui/swing/script/highliters

As long as the name matches it should work and that would remove the dependency issue. But obviously that is perhaps not the most elegant solution.

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/python-syntax-highlighting-stopped-working-in-fiji-script-editor/83615/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants