-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] .viz.pulls for normfactors #341
Comments
Thanks for raising this! Unconstrained parameters do not fit very well into this plot. I like the idea of just showing the best-fit value and uncertainty as text, alternatively we could filter out such parameters automatically. Currently this can be done manually via the Once conceptual difficulty is that the function currently does not have access to the information about which parameter is unconstrained. We could either add that to the Another thing to consider would be |
Hah indeed, I was using |
There currently is a hardcoded exclusion for parameters called cabinetry/src/cabinetry/visualize/__init__.py Lines 482 to 483 in fce7208
which is not very elegant and will fail if users call them differently (which they are free to do). I think it would be great to do both, as you suggest:
We're currently using cabinetry/src/cabinetry/route.py Line 180 in fce7208
|
Hi, just stumbled across this issue. I have an implementation for the exclusion by parameter type in my fork of cabinetry. If this is still of interest, I could open a PR? Edit: Ah, nevermind, I see it being discussed in #342 already. |
.visualize.pulls
Should only show the value (maybe just numeric) for unconstrained paramsThe text was updated successfully, but these errors were encountered: