Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a nox session for disassemble tests #534

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

dpshelio
Copy link
Contributor

@dpshelio dpshelio commented Dec 3, 2024


Description

Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.

Adds a nox session for disassemble tests as suggested on #532

Note that --system introduced in #511 was removed (unclear why that was needed).

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ pytest --doctest-plus src/vector/ or $ nox -s doctests)

Before Merging

  • Summarize the commit messages into a brief review of the Pull request.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dpshelio! Minor suggestions below and then this should be ready to go!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@dpshelio dpshelio requested a review from Saransh-cpp December 3, 2024 12:11
@Saransh-cpp Saransh-cpp merged commit 599dd0d into scikit-hep:main Dec 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants