Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a __version__ attribute to this library #90

Open
sugatoray opened this issue Dec 15, 2020 · 2 comments
Open

Please add a __version__ attribute to this library #90

sugatoray opened this issue Dec 15, 2020 · 2 comments

Comments

@sugatoray
Copy link

sugatoray commented Dec 15, 2020

It is often useful to make a note of the version of the various libraries used in a study. I personally prefer using the package.__version__ attribute whenever I can at the top of any notebook. This helps highlighting later on which version of a certain library I had used, even when I am just glancing over the notebooks and not running them explicitly.

I would request you to consider adding a boruta.__version__ attribute.

🔥 As a reference, please take a look at this issue for pyteomics library which used some strategies from the mendley repo.

@JacksonBurns
Copy link

Check out this StackOverflow answer, it has a workaround that does not require boruta.__version__. Some other answers on the same question seem to indicate that the __version__ attribute convention is not going to be around much longer, anyway.

@PierreSnell
Copy link

To install with a tool like poetry the current setup is not valid :

poetry add git+https://github.com/scikit-learn-contrib/boruta_py.git
>>> Invalid version '{{VERSION_PLACEHOLDER}}' on package boruta

I don't mean to add a __version__ but at least an option so we can install from source as pypi seems outdated (or update the pypi version).

Thanks a lot for this tool, it's really nice to work with and for my case often outperforms other methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants