From 8194a41dc760ad570fca5c2cc92a120ac9711270 Mon Sep 17 00:00:00 2001 From: Badr-MOUFAD Date: Wed, 25 Oct 2023 23:02:54 +0200 Subject: [PATCH] mm remarks --- skglm/datafits/multi_task.py | 1 - skglm/solvers/anderson_cd.py | 4 ++-- skglm/solvers/common.py | 2 +- skglm/solvers/multitask_bcd.py | 1 - 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/skglm/datafits/multi_task.py b/skglm/datafits/multi_task.py index 4dc42d769..7156a88b8 100644 --- a/skglm/datafits/multi_task.py +++ b/skglm/datafits/multi_task.py @@ -40,7 +40,6 @@ def get_lipschitz(self, X, Y): return lipschitz def get_lipschitz_sparse(self, X_data, X_indptr, X_indices, Y): - """Pre-computations before fitting on X and Y, when X is sparse.""" n_samples, n_tasks = Y.shape n_features = len(X_indptr) - 1 diff --git a/skglm/solvers/anderson_cd.py b/skglm/solvers/anderson_cd.py index 4b2886c71..4b8984b0b 100644 --- a/skglm/solvers/anderson_cd.py +++ b/skglm/solvers/anderson_cd.py @@ -285,7 +285,7 @@ def _cd_epoch(X, y, w, Xw, lc, datafit, penalty, ws): Model fit. lc : array, shape (n_features,) - Lipschitz constants of the features. + Coordinatewise gradient Lipschitz constants. datafit : Datafit Datafit. @@ -332,7 +332,7 @@ def _cd_epoch_sparse(X_data, X_indptr, X_indices, y, w, Xw, lc, datafit, penalty Model fit. lc : array, shape (n_features,) - Lipschitz constants of the features. + Coordinatewise gradient Lipschitz constants. datafit : Datafit Datafit. diff --git a/skglm/solvers/common.py b/skglm/solvers/common.py index 9588f2d52..b6cc37bba 100644 --- a/skglm/solvers/common.py +++ b/skglm/solvers/common.py @@ -15,7 +15,7 @@ def dist_fix_point(w, grad_ws, lipschitz, datafit, penalty, ws): Gradient restricted to the working set. lipschitz : array, shape (n_features,) - Lipschitz constants of the features. + Coordinatewise gradient Lipschitz constants. datafit: instance of BaseDatafit Datafit. diff --git a/skglm/solvers/multitask_bcd.py b/skglm/solvers/multitask_bcd.py index ff679e1cd..0127c0edd 100644 --- a/skglm/solvers/multitask_bcd.py +++ b/skglm/solvers/multitask_bcd.py @@ -366,7 +366,6 @@ def _bcd_epoch(X, Y, W, XW, lc, datafit, penalty, ws): lc : array, shape (n_features,) Lipschitz constants of each bloc. - datafit : instance of BaseMultiTaskDatafit Datafit.