From b4c4c695daf7ab03a6d59d72a3d2847ecc8f05e2 Mon Sep 17 00:00:00 2001 From: Stefan Vigerske Date: Sat, 9 Sep 2023 17:56:10 +0200 Subject: [PATCH] remove -Wctor-dtor-privacy for soplex - soplex seems to have decided to include the fmt library - when compiling lpi_spx2, the fmt header (included by soplex.h) needs to be compiled now - however, fmt headers generate ctor-dtor-privacy warning - as in integer/soplex@d377249db958aa16a6e539bbc1324188066c877f, this change removes checking for this warning --- CMakeLists.txt | 2 +- make/make.project | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4e44dafa35..d34a414e48 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -254,7 +254,7 @@ endif() # if changing these flags, also update GCCWARN/GXXWARN in make/make.project set(ADD_C_AND_CXX_FLAGS -pedantic -Wall -W -Wpointer-arith -Wcast-align -Wwrite-strings -Wshadow -Wredundant-decls -Wdisabled-optimization -Wno-long-long -Wno-unknown-pragmas -Wno-unused-parameter) set(ADD_C_FLAGS -Wsign-compare -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -Wno-override-init -Wno-uninitialized -Wno-maybe-uninitialized) -set(ADD_CXX_FLAGS -Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual -Wno-strict-overflow -Wno-psabi) +set(ADD_CXX_FLAGS -Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual -Wno-strict-overflow -Wno-psabi) if(CMAKE_CXX_COMPILER_ID MATCHES "Clang") # clang specific suppressions diff --git a/make/make.project b/make/make.project index 51fa59c27f..bfbb13d1be 100644 --- a/make/make.project +++ b/make/make.project @@ -244,7 +244,7 @@ GXXWARN = -pedantic -Wall -W GCCWARN += -Wpointer-arith -Wcast-align -Wwrite-strings -Wshadow -Wredundant-decls -Wdisabled-optimization \ -Wsign-compare -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes GXXWARN += -Wpointer-arith -Wcast-align -Wwrite-strings -Wshadow -Wredundant-decls -Wdisabled-optimization \ - -Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual + -Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual # disable some warning that would be too much effort to fix, disfigure the code, or produce too many false positive GCCWARN += -Wno-long-long -Wno-unknown-pragmas -Wno-unused-parameter -Wno-override-init -Wno-uninitialized -Wno-maybe-uninitialized