Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tox -e deps is senstive to the python version while updating nightly scipp release. #163

Open
MridulS opened this issue Apr 23, 2024 · 3 comments

Comments

@MridulS
Copy link
Member

MridulS commented Apr 23, 2024

Running tox -e deps in a python env which doesn't sync with python-version-ci will lead to problems where the CI is running a different python in the runner vs the scipp nightly release.

@SimonHeybrock
Copy link
Member

Yes, that appears to be how tox works. Is there a way of preventing that?

@MridulS
Copy link
Member Author

MridulS commented Apr 23, 2024

We can enforce that tox -e deps also syncs up python-version-ci so atleast we can catch these issues.

Or the CI itself should be running the tox action and creating a new PR :D

@jl-wynen
Copy link
Member

I think selecting a specific Python version in the deps env would be fine. It would prevent running the update with an incorrect version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants