Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version conflict during a version upgrade #184

Open
jl-wynen opened this issue May 29, 2024 · 1 comment
Open

Python version conflict during a version upgrade #184

jl-wynen opened this issue May 29, 2024 · 1 comment

Comments

@jl-wynen
Copy link
Member

When dropping support for a Python version, the 'Nightly tests at latest release' workflow is broken until a new release is made. (If it uses Scipp)

As an example:

  1. Release package with, e.g., Python 3.9.
  2. Set minimum to 3.10.
  3. Update dependencies.
    • This will start using the py310 wheel of scipp.
  4. Run nightly_at_release.yml.
    • This calls test.yml with tox-env: nightly and python-version: 3.10.
    • test.yml checks out the last release tag, installs Python 3.10 and runs tox -e nightly.
    • Tox installs dependencies from requirements/nightly.txt as it was at the release. I.e., it tries to install the py39 wheel for Scipp and fail.

We could mitigate this by requiring to make a release whenever we change the minimum Python version. But those releases are not necessarily meaningful.

I don't see a simple way around this. We might have to pull requirements/nightly.txt from main instead of a release tag. But that would probably cause problems as well.

@MridulS
Copy link
Member

MridulS commented May 29, 2024

We could mitigate this by requiring to make a release whenever we change the minimum Python version. But those releases are not necessarily meaningful.

I think it's perfectly fine to make releases whenever the min python version is bumped. We don't need the releases to be packed with a lot of new stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants