react

Schibsted Spain React/JSX Style Guide

A mostly reasonable approach to React and JSX

Table of Contents

1. Basic Rules
2. Naming
3. Declaration
4. Alignment
5. Quotes
6. Spacing
7. Props
8. Parentheses
9. Tags
10. Methods
11. Ordering

Basic Rules

• Only include one React component per file.
• Always use JSX syntax.
• Do not use React.createElement unless you're initializing the app from a file that is not JSX.

Class vs React.createClass

• Use class extends React.Component unless you have a very good reason to use mixins.

// bad
const Checkbox = React.createClass({
  render() {
    <div>
      <input type="checkbox" checked={this.props.checked} />
    </div>
  }
});

// good
class Checkbox extends React.Component {
  render() {
    <div>
      <input type="checkbox" checked={this.props.checked} />
    </div>
  }
}

// better (stateless functions, react 0.14 and up only)
// https://github.com/reactjs/react-future/blob/master/01%20-%20Core/03%20-%20Stateless%20Functions.js
const Checkbox = ({ checked = false }) => {
  return (
    <div>
      <input type="checkbox" checked={checked} />
    </div>
  );
};

Naming

• Extensions: Use .jsx extension for React components.

• Filename: Use PascalCase for filenames. E.g., ReservationCard.jsx.

• Reference Naming: Use PascalCase for React components and camelCase for their instances:

  // bad
  const reservationCard = require('./ReservationCard');
  
  // good
  const ReservationCard = require('./ReservationCard');
  
  // bad
  const ReservationItem = <ReservationCard />;
  
  // good
  const reservationItem = <ReservationCard />;

  Component Naming: Use the filename as the component name. For example, ReservationCard.jsx should have a reference name of ReservationCard. However, for root components of a directory, use index.jsx as the filename and use the directory name as the component name:

  // bad
  const Footer = require('./Footer/Footer.jsx')
  
  // bad
  const Footer = require('./Footer/index.jsx')
  
  // good
  const Footer = require('./Footer')

Declaration

• Do not use displayName for naming components. Instead, name the component by reference.

  // bad
  export default React.createClass({
    displayName: 'ReservationCard',
    // stuff goes here
  });
  
  // good
  class ReservationCard extends React.Component {
  }
  
  export default ReservationCard;

Alignment

• Follow these alignment styles for JSX syntax

  // bad
  <Foo superLongParam="bar"
       anotherSuperLongParam="baz" />
  
  // good
  <Foo
    superLongParam="bar"
    anotherSuperLongParam="baz"
  />
  
  // if props fit in one line then keep it on the same line
  <Foo bar="bar" />
  
  // children get indented normally
  <Foo
    superLongParam="bar"
    anotherSuperLongParam="baz"
  >
    <Spazz />
  </Foo>

Quotes

• Always use double quotes (") for JSX attributes, but single quotes for all other JS.

  // bad
  <Foo bar='bar' />
  
  // good
  <Foo bar="bar" />
  
  // bad
  <Foo style={{ left: "20px" }} />
  
  // good
  <Foo style={{ left: '20px' }} />

Spacing

• Always include a single space in your self-closing tag.

  // bad
  <Foo/>
  
  // very bad
  <Foo                 />
  
  // bad
  <Foo
   />
  
  // good
  <Foo />

Props

• Always use camelCase for prop names.

  // bad
  <Foo
    UserName="hello"
    phone_number={12345678}
  />
  
  // good
  <Foo
    userName="hello"
    phoneNumber={12345678}
  />

Parentheses

• Wrap JSX tags in parentheses when they span more than one line:

  /// bad
  render() {
    return <MyComponent className="long body" foo="bar">
             <MyChild />
           </MyComponent>;
  }
  
  // good
  render() {
    return (
      <MyComponent className="long body" foo="bar">
        <MyChild />
      </MyComponent>
    );
  }
  
  // good, when single line
  render() {
    const body = <div>hello</div>;
    return <MyComponent>{body}</MyComponent>;
  }

Tags

• Always self-close tags that have no children.

  // bad
  <Foo className="stuff"></Foo>
  
  // good
  <Foo className="stuff" />

• If your component has multi-line properties, close its tag on a new line.

  // bad
  <Foo
    bar="bar"
    baz="baz" />
  
  // good
  <Foo
    bar="bar"
    baz="baz"
  />

Methods

• Do not use underscore prefix for internal methods of a React component.

  // bad
  React.createClass({
    _onClickSubmit() {
      // do stuff
    }
  
    // other stuff
  });
  
  // good
  class extends React.Component {
    onClickSubmit() {
      // do stuff
    }
  
    // other stuff
  });

Ordering

• Ordering for class extends React.Component:

1. constructor
2. optional static methods
3. getChildContext
4. componentWillMount
5. componentDidMount
6. componentWillReceiveProps
7. shouldComponentUpdate
8. componentWillUpdate
9. componentDidUpdate
10. componentWillUnmount
11. clickHandlers or eventHandlers like onClickSubmit() or onChangeDescription()
12. getter methods for render like getSelectReason() or getFooterContent()
13. Optional render methods like renderNavigation() or renderProfilePicture()
14. render

• How to define propTypes, defaultProps, contextTypes, etc...

import React, { Component, PropTypes } from 'react';

export const propTypes = {
  id: PropTypes.number.isRequired,
  url: PropTypes.string.isRequired,
  text: PropTypes.string,
};

const defaultProps = {
  text: 'Hello World',
};

class Link extends Component {
  static methodsAreOk() {
    return true;
  }

  render() {
    return <a href={this.props.url} data-id={this.props.id}>{this.props.text}</a>
  }
}

Link.propTypes = propTypes;
Link.defaultProps = defaultProps;

export default Link;

• Ordering for React.createClass:

1. displayName
2. propTypes
3. contextTypes
4. childContextTypes
5. mixins
6. statics
7. defaultProps
8. getDefaultProps
9. getInitialState
10. getChildContext
11. componentWillMount
12. componentDidMount
13. componentWillReceiveProps
14. shouldComponentUpdate
15. componentWillUpdate
16. componentDidUpdate
17. componentWillUnmount
18. clickHandlers or eventHandlers like onClickSubmit() or onChangeDescription()
19. getter methods for render like getSelectReason() or getFooterContent()
20. Optional render methods like renderNavigation() or renderProfilePicture()
21. render

⬆ back to top