Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not updated to be compatible with replays of version 1.32 yet? #16

Open
lukas2342 opened this issue Jul 8, 2021 · 2 comments · May be fixed by #17
Open

Not updated to be compatible with replays of version 1.32 yet? #16

lukas2342 opened this issue Jul 8, 2021 · 2 comments · May be fixed by #17

Comments

@lukas2342
Copy link

I just tried to open the replay from https://warcraft3.info/replays/59360 by cloning and running the exact code from readme.rst. Unfortunately I got a UnicodeDecodeError. I guess that's due to your code not being updated to the latest wc3 version yet? Is it still being maintained?

@debaser19
Copy link

also running into the same. appears it hasn't been updated for 1.32. dev hasn't updated since 2020 so i don't think this project is still alive, unfortunately

@manh4wk
Copy link
Contributor

manh4wk commented Jan 18, 2023

It looks like Blizzard changed how they're storing some of the reforged player metadata (player id number, battle tag, clan, portrait, and maybe more) with patch 1.32.10. I'm not seeing the clan information in it anymore, but it looks like they may have added in the portrait ID? I can't change my portrait in WC3 to test it out for some reason, is that functionality broken right now? I also haven't looked much at how patches 1.33 and 1.34 impact it, and we've got 1.35 right around the corner.

The w3gjs package handled this update by using a protobuff serializer with a given schema. I tried running some replays through it though, and it doesn't look like it's picking up all the information that's there.

I guess getting this working will entail looking at that particular segment of the replays byte by byte for all the patches from 1.32.10 forwards, and coding up whatever variations appear. I don't know if Bnet replays will have different info in them than other games too, like Warcraft 3 Champions. This will take a bit to sift through.

@manh4wk manh4wk linked a pull request Feb 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants