Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX:Issue# 847 Remove step not working in tutorial creation #849

Merged
merged 3 commits into from
Aug 17, 2023
Merged

FIX:Issue# 847 Remove step not working in tutorial creation #849

merged 3 commits into from
Aug 17, 2023

Conversation

Matrx123
Copy link
Contributor

@Matrx123 Matrx123 commented Aug 6, 2023

Fixes done #847 Remove step not working in tutorial creation

Description

Fixed the issue in which on clicking the remove button selected tutorial step was not deleting.

Related Issue

None

Motivation and Context

This change was required as the tutorial steps were not deleting.
While deleting the selected step the page was reloading due to implementation of react "form" element, due to which page was reloading and execution was not reaching the remove tutorial steps function.

How Has This Been Tested?

I have implemented the change and recreate the Issue described on the Issue description.
i exactly followed what has been described in the original Issue and gone through those steps after implementation.

Screenshots or GIF (In case of UI changes):

Before Fix:
Buggy issue#847.webm

After Fix:
Fix issue#847.webm

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@Matrx123 Matrx123 changed the title FIX:Issue# 847 Remove step not working in tutorial creation FIX:Issue# 849 Remove step not working in tutorial creation Aug 7, 2023
@Matrx123 Matrx123 changed the title FIX:Issue# 849 Remove step not working in tutorial creation FIX:Issue# 847 Remove step not working in tutorial creation Aug 7, 2023
@Matrx123
Copy link
Contributor Author

hi @shivareddy6 i have commited the changes, please review those.
Thanks

@Matrx123
Copy link
Contributor Author

Matrx123 commented Aug 10, 2023 via email

@shivareddy6 shivareddy6 merged commit cd67173 into scorelab:master Aug 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants