Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pictures (ausgeschnittene bilder & darkmode) #203

Open
aladwani opened this issue Jan 25, 2024 · 1 comment
Open

Get pictures (ausgeschnittene bilder & darkmode) #203

aladwani opened this issue Jan 25, 2024 · 1 comment
Assignees
Labels
feature New feature or request upload

Comments

@aladwani
Copy link
Collaborator

wight und highed in pixel

bilder vordefinieren in pixel

Qualitaet der bilder von designerin anfragen

LOGO's svg
logo's ivnertiert svg
logo's in png / jpeg
svg groessere

@bodobraegger
Copy link
Collaborator

Ideally, we get the pictures used in each chapter / article in a way that works for both light and dark mode, although I am leaning towards dropping support for the dark mode as it requires a lot of work to maintain two image sets.

To get the website to perform better, we would need to implement the following:

https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images

I do not know if there is some built in strapi support for this - then I could modify the image links to include screen size to get the correct version.

https://developer.chrome.com/docs/lighthouse/performance/uses-responsive-images/

If you could check how we can do this with Strapi, ideally without affecting the editors writing the markdown, it could be huge @jimmylevell.

As far as the design goes:
I would really defer the decision on which imagery used where to the designers. If it is possible to have a redesign with something like white / black borders that work for both light and dark mode, it would be nice, but I think it is also fine to stay close to the source i.e. the book, and go white mode only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request upload
Projects
None yet
Development

No branches or pull requests

3 participants