Database State Root

[frisitano]

Describe the bug

When syncing the scroll chain using --debug.tip incrementally (i.e. syncing to block 10 and then doing a second run to sync to block 100) we have errors with the state root. I suspect this is due to some issue related to trie data stored in the database. We must investigate this and identify the cause.

Steps to reproduce

RUST_LOG=debug cargo run --bin scroll-reth --features scroll --manifest-path crates/scroll/bin/Cargo.toml -- node --chain scroll-mainnet --debug.tip 0xd73993f9db2b3f3cf884a2d0ae8b5e695cfcfe36b856c6ec334334de7f2f2fdb

RUST_LOG=debug cargo run --bin scroll-reth --features scroll --manifest-path crates/scroll/bin/Cargo.toml -- node --chain scroll-mainnet --debug.tip 0xce5b5c594918c338a260ea642a05213d2ebfdf6065787d3b9920dc9de62fedd4

Node logs

No response

Platform(s)

Mac (Apple Silicon)

What version/commit are you on?

reth-scroll-cli Version: 1.1.2-dev
Commit SHA: f0dca57
Build Timestamp: 2024-12-12T15:11:59.038065000Z
Build Features: scroll
Build Profile: debug

What database version are you on?

.

Which chain / network are you on?

scroll-mainnet

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

• I agree to follow the Code of Conduct

[frisitano]

This issue is related to the PrefixSetLoader. When we unpack into Nibbles in the PrefixSetLoader we should unpack into bits when the scroll feature is activated.

reth/crates/trie/db/src/prefix_set.rs

Lines 48 to 59 in f329794

	// Walk account changeset and insert account prefixes.
	let mut account_changeset_cursor = self.cursor_read::<tables::AccountChangeSets>()?;
	let mut account_hashed_state_cursor = self.cursor_read::<tables::HashedAccounts>()?;
	for account_entry in account_changeset_cursor.walk_range(range.clone())? {
	let (_, AccountBeforeTx { address, .. }) = account_entry?;
	let hashed_address = KH::hash_key(address);
	account_prefix_set.insert(Nibbles::unpack(hashed_address));
	if account_hashed_state_cursor.seek_exact(hashed_address)?.is_none() {
	destroyed_accounts.insert(hashed_address);
	}
	}

In #81, we modify this to unpack the bits when the scroll feature flag is activated. We also add this modification to other parts of the code relevant to scroll.