Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scroll execution strategy #63

Merged
merged 37 commits into from
Dec 10, 2024
Merged

feat: scroll execution strategy #63

merged 37 commits into from
Dec 10, 2024

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Dec 4, 2024 •
edited
Loading

This PR introduces an implementation of the BlockExecutionStrategy for Scroll.
It also patches the revm crate to the scroll fork.

Resolves #5

@greged93
add l1_fee field to Receipt
16d56c8 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
scroll consensus
8ac2d23 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
feat: scroll execution strategy
54c1fd2 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
feat: expose verify_receipts from reth-ethereum-consensus
5183d5a 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
feat: add reth-scroll-evm crate to avoid cyclic dep
36adba4 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
improve curie fork application + test
38569b3 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
integrate l1 fee
f431ef1 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
add ScrollEvmConfig
86945bd 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
add tests for ScrollEvmConfig
63c1986 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
add tests for ScrollExecutionStrategy
f828ab4 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
add l1 message test for ScrollExecutionStrategy
9d1c225 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
add legacy tx execution test for ScrollExecutionStrategy
5a100be 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
Merge branch 'scroll' into feat/execution-strategy
19a0b73
@greged93
use revm scroll fork
ed2f736 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
introduce ScrollExecutionStrategyFactory
dc30358 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
feat: patch revm crate to scroll fork
5c9ec2d 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
fix: lints
f6293f4 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
Merge branch 'scroll' into feat/execution-strategy
d4374f1
@greged93 greged93 marked this pull request as draft December 4, 2024 12:10
@greged93
fix: deny
178979e 
Signed-off-by: Gregory Edison <[email protected]>
@frisitano frisitano mentioned this pull request Dec 6, 2024
Merged
frisitano
frisitano reviewed Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments and questions in line. Will review more thoroughly once we integrate the chain spec.

crates/scroll/consensus/src/curie.rs Show resolved Hide resolved
crates/scroll/consensus/src/curie.rs Show resolved Hide resolved
crates/scroll/consensus/src/curie.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
crates/scroll/consensus/src/curie.rs Outdated Show resolved Hide resolved
crates/scroll/evm/Cargo.toml Show resolved Hide resolved
crates/scroll/evm/src/config.rs Show resolved Hide resolved
crates/scroll/evm/src/config.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/config.rs Show resolved Hide resolved
crates/scroll/evm/src/execute.rs Outdated Show resolved Hide resolved
frisitano
frisitano reviewed Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment left inline.

crates/scroll/consensus/src/curie.rs Show resolved Hide resolved
@greged93 greged93 mentioned this pull request Dec 7, 2024
Open
@greged93 greged93 marked this pull request as ready for review December 9, 2024 12:12
frisitano
frisitano requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few comments inline.

crates/scroll/chainspec/src/genesis.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/config.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/error.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/execute.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/execute.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/execute.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/execute.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/execute.rs Outdated Show resolved Hide resolved
@greged93
answer comments
2d78cc4 
Signed-off-by: Gregory Edison <[email protected]>
@greged93
lint
108c355 
Signed-off-by: Gregory Edison <[email protected]>
frisitano
frisitano previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left minor nits / question inline. After that we can merge.

crates/scroll/chainspec/src/constants.rs Outdated Show resolved Hide resolved
crates/scroll/chainspec/src/constants.rs Outdated Show resolved Hide resolved
crates/scroll/evm/src/config.rs Show resolved Hide resolved
@greged93
answer comments
05f2a85 
Signed-off-by: Gregory Edison <[email protected]>
frisitano
frisitano approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Lets wait for CI to finish and then we can merge.

@greged93 greged93 merged commit d953c47 into scroll Dec 10, 2024
41 checks passed
@greged93 greged93 deleted the feat/execution-strategy branch December 10, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisitano frisitano frisitano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll EvmExecutor implementation
2 participants
@greged93 @frisitano