Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prod branch from develop #88

Merged
merged 16 commits into from
Sep 18, 2023
Merged

Update prod branch from develop #88

merged 16 commits into from
Sep 18, 2023

Conversation

Turupawn
Copy link
Member

Description

There are currently some errors such as broken or wrong links. Also some places where the branding is not up to date. Many were fixed and are currently on the develop branch. This issues are currently live on production and I think we should update them now.

Changes

  • Broken or wrong links
  • Missing or wrong what's next buttons
  • Branding not up to date in some places

knikolaeff and others added 12 commits August 23, 2023 16:39
Fix: faucet link broken because of the double slash
when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.
* add bware faucet

* fix dangling html close comment
* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* update press link and change zero-knowledge to zero knowledge

---------

Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* fix: Apple touch icon 256x256 (#68)

* Update prod for rebrand. (#71)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

* fix: apply new logo (#66)

* Rebranding (#69)

* Update: 8/23/23 (#65)

* Removed trailing slashes in the urls (#63)

Fix: faucet link broken because of the double slash

* Fix: What's next link on ERC721 bridge page

when you're on ERC721 NFT Bridge page and scrolling down to whats next you see ERC1155 Token Bridge tap, when you click on it. it doesn't take you to ERC1155 Token Bridge page. it will reload the same page. so i fixed by editing the whats next line.

* Update: Add Bware Faucet (#64)

* add bware faucet

* fix dangling html close comment

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>

* fix: apply new logo (#67)

* update press link and change zero-knowledge to zero knowledge

---------

Co-authored-by: Daniel Helm <[email protected]>
Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>

---------

Co-authored-by: Kirill Nikolaev <[email protected]>
Co-authored-by: monem <[email protected]>
Co-authored-by: Holybasil <[email protected]>
Co-authored-by: zzq0826 <[email protected]>
* update: new banner

* add badges
@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit 28ac645
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/65089d1333cbf300095465f8
😎 Deploy Preview https://deploy-preview-88.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Turupawn Turupawn requested review from dghelm and icemelon September 12, 2023 18:37
antonleviathan and others added 3 commits September 17, 2023 20:58
* Update bridge-erc20-through-the-custom-gateway.mdx

Fixed wrong address

* Update bridge-erc20-through-the-custom-gateway.mdx
Open a new target URL in new tab, current its  overriding this page(main domain)
dghelm
dghelm previously approved these changes Sep 18, 2023
@dghelm dghelm dismissed their stale review September 18, 2023 18:55

The merge-base changed after approval.

@dghelm dghelm merged commit f5cdd43 into prod Sep 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.