Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sp1 prover for halo2 + sp1 chunks #353

Draft
wants to merge 52 commits into
base: main
Choose a base branch
from
Draft

Sp1 prover for halo2 + sp1 chunks #353

wants to merge 52 commits into from

Conversation

noel2004
Copy link
Member

@noel2004 noel2004 commented Nov 17, 2024 •
edited
Loading

This PR have absorbed commites in #352 and provided a one step generation of chunk proof which come from sp1

It has synced with the up-to-date zkevm-circuit and main branch.

Notice: we need to set the sproll program (the elf file) under integration path

Everything should be ok after

  • generate chunk proof successfully
  • pass tests for (hybrid) batch circuit
  • pass regression e2e test

Following tasks is required after this PR:

  • The test examples for batch proving tests has been outdated

noel2004 and others added 30 commits October 3, 2024 11:01
@noel2004
sp1 chunk test
48e3de4
@noel2004
renaming snark
2f637c5 
Signed-off-by: noelwei <[email protected]>
@noel2004
fix naming
ae9cc80 
Signed-off-by: noelwei <[email protected]>
@noel2004
refactoring sp1 test
7c7c458 
Signed-off-by: noelwei <[email protected]>
@noel2004
resume path extracting
6a6c467 
Signed-off-by: noelwei <[email protected]>
@noel2004
test for integrating sp1 to batch
a4f9490 
Signed-off-by: noelwei <[email protected]>
@noel2004
purge uncessary dumping
3e92fa2 
Signed-off-by: noelwei <[email protected]>
@noel2004
e2e support sp1 path
37e41f6 
Signed-off-by: noelwei <[email protected]>
@noel2004
lints
6cf60cf 
Signed-off-by: noelwei <[email protected]>
@noel2004
add testing stuff for sp1
1491df4 
Signed-off-by: noelwei <[email protected]>
@noel2004
add PI digest log
592156c 
Signed-off-by: noelwei <[email protected]>
@lispc
update testing stuff
b1e121b
@noel2004
fix an issue in restore results
595b742 
Signed-off-by: noelwei <[email protected]>
@noel2004
more fixing
c6ab340 
Signed-off-by: noelwei <[email protected]>
@noel2004
also fix issue for zkevm-chunk-test
332fc3b 
Signed-off-by: noelwei <[email protected]>
@noel2004
add post batch test
520609c 
Signed-off-by: noelwei <[email protected]>
@roynalnaruto
update deps
cee1921
@roynalnaruto
add verifier deployment test
0ce4fa7
@roynalnaruto
more verifier deploy test (snark-verifier, not revm)
df43565
@roynalnaruto
tmp: add evm verifier bin
90f3f71
@roynalnaruto
bump zkevm-circuits:prover
a0e6c66
@roynalnaruto
poseidon-circuit dep correct as per rust-toolchain
bf73b34
@roynalnaruto
use prover's export instead of snark-verifier-sdk
7be636d
@roynalnaruto
e2e hybrid test setup
714f6b7
@roynalnaruto
fix: hybrid batch dir
c8211e8
@roynalnaruto
variants for chunk protocol in batch prover
dbb72a7
@roynalnaruto
bump prover and snark-verifier
d0ef2f7
@roynalnaruto
bump prover
db65938
@roynalnaruto
bump prover
19c6328
@roynalnaruto
bum prover
0b60e64
roynalnaruto and others added 18 commits October 18, 2024 14:34
@roynalnaruto
bump prover
ad2c90e
@roynalnaruto
bump prover
00a0052
@roynalnaruto
bump prover
38baee7
@roynalnaruto
bump prover
42eb985
@noel2004
init prover and sp1 prover
b1e26cf 
Signed-off-by: noelwei <[email protected]>
@roynalnaruto
Merge branch 'main' into feat/hybrid-snark-agg
0b78006
@roynalnaruto
compile + clippy
7bb2795
@lispc
minor fix
1a7da0e
@noel2004
resolve all dep issues
69f9043 
Signed-off-by: noelwei <[email protected]>
@noel2004
sp1 prover first commit
c24a50f 
Signed-off-by: noelwei <[email protected]>
@noel2004
Merge remote-tracking branch 'origin/main' into sp1-prover
065e884 
Signed-off-by: noelwei <[email protected]>
@noel2004
fix after merging
f822f30 
Signed-off-by: noelwei <[email protected]>
@noel2004
add default sp1-halo2-backend param
e3c6369 
Signed-off-by: noelwei <[email protected]>
@noel2004
induce compatible load chunk
f6822d4 
Signed-off-by: noelwei <[email protected]>
@noel2004
enforce env var
6aa4590 
Signed-off-by: noelwei <[email protected]>
@noel2004
Merge remote-tracking branch 'origin/feat/hybrid-snark-agg' into sp1-…
fbcaaf8 
…prover
@noel2004
refine tests
bcc31ee 
Signed-off-by: noelwei <[email protected]>
@noel2004
refine sp1 prover: loading and support new traces
5ff19d3 
Signed-off-by: noelwei <[email protected]>
@noel2004 noel2004 mentioned this pull request Nov 17, 2024
Open
@noel2004 noel2004 requested a review from lispc November 17, 2024 11:52
@noel2004
Copy link
Member Author

e2e test passed (e2e_tests_20241121_090129)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lispc lispc Awaiting requested review from lispc

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noel2004 @lispc @roynalnaruto