Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop in determining basePath #31

Open
marcovtwout opened this issue May 1, 2017 · 1 comment
Open

Infinite loop in determining basePath #31

marcovtwout opened this issue May 1, 2017 · 1 comment

Comments

@marcovtwout
Copy link
Contributor

On Windows, if you run the upload command and .git is not in any parent directory, you get an infinite loop: https://github.com/scrutinizer-ci/ocular/blob/master/src/Scrutinizer/Ocular/Command/CodeCoverage/UploadCommand.php#L104

$dir will eventually become the drive letter, for example: C:\
@marcovtwout
Copy link
Contributor Author

#32 Fixes a related issue (but not this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcovtwout