Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split extrinsic_params file #829

Open
haerdib opened this issue Jan 31, 2025 · 0 comments
Open

Split extrinsic_params file #829

haerdib opened this issue Jan 31, 2025 · 0 comments
Labels
F5-refactor Does not change any functionality of the code Q3-substantial

Comments

@haerdib
Copy link
Contributor

haerdib commented Jan 31, 2025

PR #828 shows quite well which structs are needed for a self defined ExtrinsicParams feature. In the extrinsic_params file however, this is not visible as Traits and implementations are quite mixed.

Suggestion: Split the file into:

  • Traits
  • Helper Implementation that are needed (maybe that makes sense to keep together with the Traits)
  • Specific Node implementation. In our case it's Generic, but it's actually still just compatible with the "newest" node, though the types are generic and not hardcoded.
@haerdib haerdib added F5-refactor Does not change any functionality of the code Q3-substantial labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F5-refactor Does not change any functionality of the code Q3-substantial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haerdib