Include dataset id in visium HD reader #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, yes at some point we can do a cleanup and work on improving the cross-tech naming. This is a good start. |
|
Thanks! |
LucaMarconato
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #266, adapting the changes also for visium HD.
More generally, should a
dataset_idbe included in any format read withspatialdata-io? It seems inconsistent to do name slots by sample in some, but not in other cases.Changelog
dataset_idprefix (anddataset_idis used instead ofglobal). This makes it easier to concatenate multiple samples. Tip: tou can callsdata.rename_coordinate_systems()if you want to restore the legacy names.