Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Svelte to v4 (and other frontend dependencies) #458

Open
k0machi opened this issue Sep 18, 2024 · 3 comments
Open

Updating Svelte to v4 (and other frontend dependencies) #458

k0machi opened this issue Sep 18, 2024 · 3 comments
Assignees
Labels
Argus enhancement New feature or request

Comments

@k0machi
Copy link
Collaborator

k0machi commented Sep 18, 2024

We haven't updated our frontend dependencies in a while and the v3 branch of Svelte is getting less and less support as it's a very bleeding edge library that gets constant improvements. We should update and migrate our code to v4. Looking at the doc there, there aren't a lot of changes needed (if any), so it should be a relatively smooth procedure. However:

  • Svelte-select has breaking api changes going from our current version to latest, which would necessitate updating our usage of Select component.
  • We should update svelte-loader and webpack (or, potentially, switch to rollup for bundling, as that's the official recommendation)
  • Bootstrap could be updated as well during this.
@k0machi k0machi added enhancement New feature or request Argus labels Sep 18, 2024
@k0machi k0machi self-assigned this Sep 18, 2024
@fruch
Copy link
Contributor

fruch commented Nov 11, 2024

@k0machi

what is the added value of such update ?
is that blocking anything ?

is there any bug fixes we need from the new version ?

i.e. we need a good reason to start this thing.

@k0machi
Copy link
Collaborator Author

k0machi commented Nov 20, 2024

@k0machi

what is the added value of such update ? is that blocking anything ?

is there any bug fixes we need from the new version ?

i.e. we need a good reason to start this thing.

Libraries that we use have started requiring v4, so to update them (particularly the select component) we would need to update svelte as well. v4 migration is easy, there's just one minor change that needs to be accounted for, v5 on the other hand will require a small refactor and can be postponed.

@fruch
Copy link
Contributor

fruch commented Nov 21, 2024

@k0machi
what is the added value of such update ? is that blocking anything ?
is there any bug fixes we need from the new version ?
i.e. we need a good reason to start this thing.

Libraries that we use have started requiring v4, so to update them (particularly the select component) we would need to update svelte as well. v4 migration is easy, there's just one minor change that needs to be accounted for, v5 on the other hand will require a small refactor and can be postponed.

if we have specific library that we need to update and mante this change, let's do that in the context of that needed change.

i.e. no change for the sake of updates only, and not update too many thing at the same time, just for the sake of it. it should be small incremental changes as much as possible, not one big PR turning everything upside down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argus enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants