Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argus should not mark result as passed if all ValidationRules for given metric are empty #521

Closed
soyacz opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@soyacz
Copy link
Collaborator

soyacz commented Nov 26, 2024

In run https://argus.scylladb.com/tests/scylla-cluster-tests/9e2af03d-b1a5-4df0-b516-4ce5e624586d
I set null to all validation rules for unthrottled latencies - they were marked as green ("PASSED" status), but should be white ("UNSET" status).
This gives wrong indication that something was verified, while not.

@fruch fruch added the bug Something isn't working label Jan 2, 2025
@soyacz
Copy link
Collaborator Author

soyacz commented Jan 2, 2025

Issue is wrong, things were set through defaults. In recent perf results issue is not present.

@soyacz soyacz closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants