Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo warmup fail logic #304

Open
dkropachev opened this issue May 9, 2023 · 3 comments
Open

Redo warmup fail logic #304

dkropachev opened this issue May 9, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dkropachev
Copy link
Collaborator

Currently Warmup respects failFast and fails if there is any error in such case.
Let's have separate logic for Warmup, it should look at fail to success percentage and fail if it is greater then warmup-fail-error-rate (implement this option)
Also it can fail by this condition only after warmup-safe-period secods are passed since warmup is started.

@soyacz
Copy link
Collaborator

soyacz commented May 10, 2023

why do we need warmup in Gemini?

@dkropachev
Copy link
Collaborator Author

@soyacz , idea is that when/if cassandra is used we need to warm it up, otherwise - to fillout table with values before doing measurements.
@roydahan , roy, WDYT? do we realy need it there ?

@roydahan
Copy link
Collaborator

I don't know if we need it, i'm not sure I understand the scenario you mentioned above.

@dkropachev dkropachev added the enhancement New feature or request label Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants