Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kafka version #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bouncheck
Copy link
Collaborator

Fixes #59 .
Bumping Kafka version as a consequence removes log4j jar from dependency tree.
Before:

[wo@fedora kafka-connect-scylladb]$ mvn dependency:tree -Dincludes='*log4j*' 
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for io.kafka.connect:kafka-connect-scylladb:jar:1.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for com.mycila:license-maven-plugin is missing. @ line 53, column 21
[WARNING] 'build.plugins.plugin.version' for org.jacoco:jacoco-maven-plugin is missing. @ line 116, column 21
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 
[INFO] 
[INFO] --------------< io.kafka.connect:kafka-connect-scylladb >---------------
[INFO] Building kafka-connect-scylladb 1.0.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ kafka-connect-scylladb ---
[INFO] io.kafka.connect:kafka-connect-scylladb:jar:1.0.0-SNAPSHOT
[INFO] \- org.apache.kafka:connect-runtime:jar:2.4.0:test
[INFO]    \- org.apache.kafka:kafka-tools:jar:2.4.0:test
[INFO]       \- org.apache.kafka:kafka-log4j-appender:jar:2.4.0:test
[INFO]          \- org.slf4j:slf4j-log4j12:jar:1.7.28:test
[INFO]             \- log4j:log4j:jar:1.2.17:test
[INFO] ------------------------------------------------------------------------
[wo@fedora kafka-connect-scylladb]$ mvn dependency:tree -Dverbose=true | grep 4j
[INFO] |  +- (org.slf4j:slf4j-api:jar:1.7.28:compile - scope updated from provided; omitted for duplicate)
[INFO] |  \- (org.slf4j:slf4j-api:jar:1.7.28:provided - omitted for duplicate)
[INFO] |  |  \- (org.slf4j:slf4j-api:jar:1.7.28:compile - omitted for conflict with 1.7.25)
[INFO] |  +- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO] |  |  +- org.apache.kafka:kafka-log4j-appender:jar:2.4.0:test
[INFO] |  |  |  \- org.slf4j:slf4j-log4j12:jar:1.7.28:test
[INFO] |  |  |     +- (org.slf4j:slf4j-api:jar:1.7.28:test - omitted for conflict with 1.7.25)
[INFO] |  |  |     \- log4j:log4j:jar:1.2.17:test
[INFO] |  |  +- net.sourceforge.argparse4j:argparse4j:jar:0.7.0:test
[INFO] |  |  +- (org.slf4j:slf4j-api:jar:1.7.28:test - omitted for conflict with 1.7.25)
[INFO] |  |  \- (org.slf4j:slf4j-api:jar:1.7.28:test - omitted for conflict with 1.7.25)
[INFO] |  |  \- (org.slf4j:slf4j-api:jar:1.7.28:test - omitted for conflict with 1.7.25)
[INFO] |  +- (org.slf4j:slf4j-api:jar:1.7.28:test - omitted for conflict with 1.7.25)
[INFO] |  +- (org.slf4j:slf4j-api:jar:1.7.28:test - omitted for conflict with 1.7.25)
[INFO] |  \- (org.slf4j:slf4j-api:jar:1.7.28:test - omitted for conflict with 1.7.25)
[INFO]    +- org.opentest4j:opentest4j:jar:1.1.0:test

After:

[wo@fedora kafka-connect-scylladb]$ mvn dependency:tree -Dincludes='*log4j*' 
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for io.kafka.connect:kafka-connect-scylladb:jar:1.0.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for com.mycila:license-maven-plugin is missing. @ line 53, column 21
[WARNING] 'build.plugins.plugin.version' for org.jacoco:jacoco-maven-plugin is missing. @ line 116, column 21
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 
[INFO] 
[INFO] --------------< io.kafka.connect:kafka-connect-scylladb >---------------
[INFO] Building kafka-connect-scylladb 1.0.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ kafka-connect-scylladb ---
[INFO] ------------------------------------------------------------------------
[wo@fedora kafka-connect-scylladb]$ mvn dependency:tree -Dverbose=true | grep 4j
[INFO] |  +- (org.slf4j:slf4j-api:jar:1.7.36:compile - scope updated from provided; omitted for duplicate)
[INFO] |  \- (org.slf4j:slf4j-api:jar:1.7.36:provided - omitted for duplicate)
[INFO] |  |  \- (org.slf4j:slf4j-api:jar:1.7.36:compile - omitted for conflict with 1.7.25)
[INFO] |  +- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO] |  |  \- (org.slf4j:slf4j-api:jar:1.7.36:test - omitted for conflict with 1.7.25)
[INFO] |  |  \- (org.slf4j:slf4j-api:jar:1.7.36:test - omitted for conflict with 1.7.25)
[INFO] |  |  +- org.apache.kafka:kafka-log4j-appender:jar:3.2.0:test
[INFO] |  |  |  \- org.slf4j:slf4j-reload4j:jar:1.7.36:test
[INFO] |  |  |     +- (org.slf4j:slf4j-api:jar:1.7.36:test - omitted for conflict with 1.7.25)
[INFO] |  |  |     \- (ch.qos.reload4j:reload4j:jar:1.2.19:test - omitted for duplicate)
[INFO] |  |  +- net.sourceforge.argparse4j:argparse4j:jar:0.7.0:test
[INFO] |  |  +- (org.slf4j:slf4j-api:jar:1.7.36:test - omitted for conflict with 1.7.25)
[INFO] |  |  +- (ch.qos.reload4j:reload4j:jar:1.2.19:test - omitted for duplicate)
[INFO] |  |  +- (org.bitbucket.b_c:jose4j:jar:0.7.9:test - omitted for duplicate)
[INFO] |  +- (org.slf4j:slf4j-api:jar:1.7.36:test - omitted for conflict with 1.7.25)
[INFO] |  +- ch.qos.reload4j:reload4j:jar:1.2.19:test
[INFO] |  +- org.bitbucket.b_c:jose4j:jar:0.7.9:test
[INFO] |  |  \- (org.slf4j:slf4j-api:jar:1.7.21:test - omitted for conflict with 1.7.25)
[INFO] |  +- (org.slf4j:slf4j-api:jar:1.7.36:test - omitted for conflict with 1.7.25)
[INFO] |  +- (ch.qos.reload4j:reload4j:jar:1.2.19:test - omitted for duplicate)
[INFO] |  +- (org.bitbucket.b_c:jose4j:jar:0.7.9:test - omitted for duplicate)
[INFO] |  \- (org.slf4j:slf4j-api:jar:1.7.36:test - omitted for conflict with 1.7.25)
[INFO]    +- org.opentest4j:opentest4j:jar:1.1.0:test

Bumping Kafka version as a consequence removes log4j jar from dependency tree.
@Bouncheck Bouncheck force-pushed the log4j_version_bump branch from 4c2d6b6 to 20d416f Compare May 30, 2022 09:48
@Bouncheck Bouncheck self-assigned this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest and greatest log4j version
1 participant