Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scyll Node Role]: upgrade - check if upgrade is needed before backing up node's data #133

Open
vladzcloudius opened this issue Jun 29, 2022 · 1 comment · May be fixed by #144
Open

[Scyll Node Role]: upgrade - check if upgrade is needed before backing up node's data #133

vladzcloudius opened this issue Jun 29, 2022 · 1 comment · May be fixed by #144
Assignees
Labels
bug Something isn't working

Comments

@vladzcloudius
Copy link
Collaborator

HEAD: 365a23d

When upgrade_version: true Role is going to backup everything it backs up (including creating a snapshotof data) before even checking if any upgrade is needed.

@vladzcloudius vladzcloudius self-assigned this Jun 29, 2022
@vladzcloudius vladzcloudius added the bug Something isn't working label Jun 29, 2022
@fee-mendes
Copy link
Member

The role backs up and snapshots everything without checking whether the user provided version is a valid version upgrade OR whether it is available. It does check - however - whether the user provided input is valid from a semantics perspective (only) within upgrade/main.yml where it is able to catch most of user mistakes.

Therefore I'd consider this issue as an enhancement, rather than a bug per se.

I will submit a commit to address some aspects of the upgrade logic (for example, the fact that an upgrade to latest doesn't work), and include a check to determine whether there are upgrades available, which will fit nicely when one specifies latest but already is under whatever latest is. ;-)

@fee-mendes fee-mendes linked a pull request Jul 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants