ansible-scylla-node: prevent minor upgrade from failing when the destination scylla version is already installed #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'scylla_version: latest' is "resolved" before "upgrade" code is invoked into a scylla_version_to_install variable - use this value. Signed-off-by: Vlad Zolotarov <[email protected]>
…edition Signed-off-by: Vlad Zolotarov <[email protected]>
ebenzecri
approved these changes
Oct 16, 2024
…ation Set scylla_detected['version'] and scylla_upgrade['version'] to be a "short" scylla version so that 'version()' comparator is able to compare then without glitches. The thing is "2024.1.10" is going to be "less than" "2024.1.10-0.20240918.24a78645ca8b-1". Let's leave only MAJOR.MINOR.PATCH components of both before comparing. Fixes scylladb#415 Signed-off-by: Vlad Zolotarov <[email protected]>
…seconds" Wait for a CQL port to become available instead of waiting for 90 seconds - the latter is both unreliable and is excessive in most cases. Signed-off-by: Vlad Zolotarov <[email protected]>
Signed-off-by: Vlad Zolotarov <[email protected]>
vladzcloudius
force-pushed
the
scylla-node-upgrade-dont-fail-same-version
branch
from
00b4de6 to
dadbba5
Compare
ebenzecri
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions sanity checks only make sense when one upgrades to official builds.
For custom builds upgrades one is going to disable these sanity checks anyway using upgrade_allow_user_manual_downgrade.
Therefore we can use MAJOR.MINOR.PATCH parts of installed and to-be-installed Scylla versions for sanity checking.