Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scylla-node: Append 'dc_suffix' to dc name when GPFS is used #425

Merged

Conversation

igorribeiroduarte
Copy link
Collaborator

No description provided.

@@ -14,7 +14,7 @@
#

{% if scylla_snitch == 'GossipingPropertyFileSnitch' %}
dc={{ dc }}
dc={{ dc + dc_suffix | default('') }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a somewhat unexpected syntax. I was expecting something like this:

dc={{ dc }}{{ dc_suffix | default('') }}

Did you test your version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both these options should work

Did you test your version?

Yes, I did

@vladzcloudius vladzcloudius merged commit 7b2cde9 into scylladb:master Nov 25, 2024
2 checks passed
@igorribeiroduarte igorribeiroduarte deleted the always_use_dc_suffix branch November 25, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants