Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2024.1] feature(artifact_test): testing the output of perftune.py #9182

Draft
wants to merge 1 commit into
base: branch-2024.1
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 12, 2024

perftune.py is a script within seastar (which is a part of scylla_setup) that configures several system parameters, like the amount of CPU cores that are designated to handle IRQ, and which are not.

Ref: https://github.com/scylladb/scylla-enterprise/issues/2909

Replacement of #6192

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit a954770)

Parent PR: #8788

@mergify mergify bot added the conflicts label Nov 12, 2024
@mergify mergify bot assigned fruch Nov 12, 2024
Copy link
Author

mergify bot commented Nov 12, 2024

Cherry-pick of a954770 has failed:

On branch mergify/bp/branch-2024.1/pr-8788
Your branch is up to date with 'origin/branch-2024.1'.

You are currently cherry-picking commit a95477090.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   defaults/severities.yaml
	modified:   sdcm/sct_events/system.py
	new file:   sdcm/utils/perftune_validator.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   artifacts_test.py
	both modified:   sdcm/cluster.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot marked this pull request as draft November 12, 2024 17:57
@fruch
Copy link
Contributor

fruch commented Nov 12, 2024

moved to draft, so we won't merge those until tested

@fruch
Copy link
Contributor

fruch commented Nov 12, 2024

depedns on #9184 to be backported

perftune.py is a script within seastar (which is a part of scylla_setup)
that configures several system parameters, like the amount of CPU cores that
are designated to handle IRQ, and which are not.

I have recorded the expected results as of master 20230717.567b4536892f
in defaults/perftune_results.json, and the test will compare them to
the output of the script.

Ref: scylladb/scylla-enterprise#2909
(cherry picked from commit a954770)
@fruch fruch force-pushed the mergify/bp/branch-2024.1/pr-8788 branch from f0733f8 to df05313 Compare November 17, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants