Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-networks): configure scylla correctly with the right interface #9500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Dec 8, 2024

  • configure listen_interface in scylla.yaml as needed
  • return correct selected interface on get_nic_devices()
  • run scylla_sysconfig_setup again on right network interface

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@juliayakovlev
Copy link
Contributor

What is it wrong, why this change is needed?

@fruch
Copy link
Contributor Author

fruch commented Dec 9, 2024

What is it wrong, why this change is needed?

while investigating the job using it, I've seen that we configure all of the CPU pinning in regards of eth0
I thought it might the cause of some other issues as well I've seen in that case, but so far I showed that most of them aren't related to this change.

but it's the correct thing todo, to make sure scylla is configured correctly.

* configure `listen_interface` in scylla.yaml as needed
* return correct selected interface on `get_nic_devices()`
* run `scylla_sysconfig_setup` again on right network interface
@fruch fruch force-pushed the fix_multi_networking_setup branch from 5eba5ae to fb82378 Compare December 10, 2024 19:56
@fruch fruch marked this pull request as ready for review December 11, 2024 05:26
@fruch fruch requested review from a team and dimakr December 11, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants