Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nemesis): disrupt_remove_node_then_add_node was missing retry=0 #9546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(nemesis): disrupt_remove_node_then_add_node was missing retry=0 #9546

wants to merge 1 commit into from

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Dec 12, 2024 •
edited
Loading

in ecc2c7e long_running=True parameter was introduced, but it must come together with retry=0, and that was forgotten

Fixes: #9534

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@fruch
fix(nemesis): disrupt_remove_node_then_add_node was missing retry=0
aa0af65 
in ecc2c7e `long_running=True` paramter
was introduced, but it must come togther with `retry=0`, and that
was forgotten

Fixes: scylladb#9534
@fruch fruch added backport/2024.2 Need backport to 2024.2 backport/6.1 Need backport to 6.1 backport/6.2 labels Dec 12, 2024
@fruch fruch requested a review from a team December 13, 2024 13:59
vponomaryov
vponomaryov approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vponomaryov vponomaryov vponomaryov approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@fruch fruch

Labels
backport/6.1 Need backport to 6.1 backport/6.2 backport/2024.2 Need backport to 2024.2
Projects
None yet
Milestone
No milestone
2 participants
@fruch @vponomaryov