dist/debian: add trailer line #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for better readability Signed-off-by: Kefu Chai <[email protected]>
this should address the warnings from dpkg-source and dpkg-parsechangelog, like: ``` dpkg-source: warning: scylla-package/debian/changelog(l3): found end of file where expected more change data or trailer ``` ``` dpkg-parsechangelog: warning: debian/changelog(l3): found end of file where expected more change data or trailer ``` Signed-off-by: Kefu Chai <[email protected]>
fruch
reviewed
Jan 2, 2024
| @@ -1,3 +1,5 @@ | |||
| %{product}-cqlsh (%{version}-%{release}-%{revision}) %{codename}; urgency=medium | |||
|
|
|||
| * New release | |||
|
|
|||
| -- Israel Fruchter <[email protected]> %{timestamp} | |||
There was a problem hiding this comment.
@tchaikov nice of you to sign in my name :)
There was a problem hiding this comment.
it was you who created this changelog entry. ;-)
fruch
reviewed
Jan 2, 2024
| @@ -47,7 +48,13 @@ class DebianFilesTemplate(string.Template): | |||
| shutil.copytree('dist/debian/debian', 'build/debian/debian') | |||
|
|
|||
| s = DebianFilesTemplate(changelog_template) | |||
| changelog_applied = s.substitute(product=product, version=version, release=release, revision='1', codename='stable') | |||
| now = datetime.datetime.now(tz=datetime.timezone.utc) | |||
| changelog_applied = s.substitute(product=product, | |||
There was a problem hiding this comment.
this was done on other packages ?
There was a problem hiding this comment.
(we assumed for long time, that the change log is mostly not touched)
There was a problem hiding this comment.
not yet. i created this change in hope to silence the warnings and to comply to the debian packaging policies. will take care of other packages when i have more free cycles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should address the warnings from dpkg-source and
dpkg-parsechangelog, like: