Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scylla JMX should accept both Histogram formats #117

Open
amnonh opened this issue Jun 24, 2020 · 0 comments
Open

Scylla JMX should accept both Histogram formats #117

amnonh opened this issue Jun 24, 2020 · 0 comments
Milestone
Backlog

Comments

@amnonh
Copy link
Contributor

amnonh commented Jun 24, 2020 •
edited
Loading

There are two types of histograms, the older was deprecated a long time ago.

In MetricsRegistry JmxHistogram already support both types.
The JMXTimer should support that as well
amnonh added a commit to amnonh/scylla-jmx that referenced this issue Jun 24, 2020
@amnonh
MetricsRegistry: Support both types of histograms
6fef9d6 
There are two types of histograms, the older deprecated histogram and
the new estimated_histogram.

This patch changes the implementation of MetricsRegistry so the JmxTimer
would support both types, similiar to JmxHistogram.

Fixes scylladb#117

Signed-off-by: Amnon Heiman <[email protected]>
@amnonh amnonh mentioned this issue Jun 24, 2020
Closed
@DoronArazii DoronArazii added this to the Backlog milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

MetricsRegistry: Support both types of histograms amnonh/scylla-jmx
2 participants
@amnonh @DoronArazii