MetricsRegistry: Support both types of histograms #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two types of histograms, the older deprecated histogram and the new estimated_histogram. This patch changes the implementation of MetricsRegistry so the JmxTimer would support both types, similiar to JmxHistogram. Fixes scylladb#117 Signed-off-by: Amnon Heiman <[email protected]>
penberg
reviewed
Jul 14, 2020
| histogram = new Histogram(obj.getJsonObject("hist")); | ||
| } else if (obj.containsKey("buckets")) { | ||
| histogram = new Histogram(new EstimatedHistogram(obj)); | ||
| } |
There was a problem hiding this comment.
The logic in JmxHistogram has an additional else path:
@Override
public void update(JsonObject obj) {
if (obj.containsKey("hist")) {
obj = obj.getJsonObject("hist");
}
if (obj.containsKey("buckets")) {
histogram = new Histogram(new EstimatedHistogram(obj));
} else {
histogram = new Histogram(obj);
}
}Which one of the two is correct?
There was a problem hiding this comment.
it's mutually exclusive (it's either hist or buckets) but I'm closing this PR because I will take a different path
|
I'm going to take a different path with the implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two types of histograms, the older deprecated histogram and
the new estimated_histogram.
This patch changes the implementation of MetricsRegistry so the JmxTimer
would support both types, similiar to JmxHistogram.
Fixes #117
Signed-off-by: Amnon Heiman [email protected]