JMX footprint work #136
Merged
JMX footprint work #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scylladb#133 TableMetricObjectName is not serializable as such, since it depends on a lexicon object etc. Use writeReplace to put a regular ObjectName in the stream instead.
penberg
reviewed
Sep 7, 2020
src/main/java/com/scylladb/jmx/metrics/RegistrationChecker.java
Outdated
Show resolved
Hide resolved
Allows for shared code for synchronized and optionally partial update checks.
Fixes scylladb#134 Refs scylladb#135 Replaces previous refresh calls with ones bound to registration check objects, which provides some sync between threads doing refresh, and reduced redundant calls. Also adds repeated reaping of dead objects, i.e. every 5 minutes we try to remove dead CF:s (not adding new ones), to reduce idle footprint.
|
Fixed the above notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Fixes #134
Refs #135
Makes CF mbean refresh code synchronized and tries to remove reductant calls if we contend.
Adds background reaping of dead objects to reduce memory load in (test) scenarios where we manage
to refresh to add, but not cause removal (i.e. no wildcard queries).
TableMetricsObjectName serialization is fixed in the series because without it we see loads of
exceptions when refreshing the mbean set.