Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix github repo links #13

Merged
merged 2 commits into from
Apr 12, 2024
Merged

docs: fix github repo links #13

merged 2 commits into from
Apr 12, 2024

Conversation

dgarcia360
Copy link
Collaborator

@dgarcia360 dgarcia360 commented Apr 9, 2024

Motivation

Fixes the "open an issue" and "edit this page" buttons to point to this repository.

How to test

Clone the docs and try the buttons.

Considerations

Consider open-sourcing this repo so external users can open issues/ edit the page. Otherwise, we could link a separate repo for issues and hide the edit on this page button, as we did for the cloud docs. cc/ @annastuchlik

@dgarcia360 dgarcia360 changed the title fix: GitHub repo docs: fix github repo links Apr 9, 2024
@dgarcia360 dgarcia360 requested a review from annastuchlik April 9, 2024 14:08
@annastuchlik
Copy link
Collaborator

@dgarcia360 Now clicking the button opens the correct repo, but it's looking for the default master branch, while the default branch in this repo is "main". How can we change it?

image

@tzach Can we make this repo public? I can't see any good arguments against it?

@tzach
Copy link
Collaborator

tzach commented Apr 11, 2024

@tzach Can we make this repo public? I can't see any good arguments against it?

Yes, I do not see an issue either

@dgarcia360
Copy link
Collaborator Author

@annastuchlik Good catch! Fixed in c14b9d7

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annastuchlik
Copy link
Collaborator

@dgarcia360 Thanks! It works, so I'm merging it. Next, we'll make this repo public.

@annastuchlik annastuchlik merged commit 01fe728 into main Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants