Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update command #21

Merged
merged 2 commits into from
Sep 30, 2024
Merged

docs: update command #21

merged 2 commits into from
Sep 30, 2024

Conversation

dgarcia360
Copy link
Collaborator

Related issue scylladb/sphinx-scylladb-theme#849

Separates the update command from the setup command.

This is required because versions now are not strictly pinned in the pyproject.toml file since Sphinx ScyllaDB Theme 1.8. This change makes sure that the versions defined in the poetry.lock file committed to the repository are the ones used for production builds.

How to test

  1. Build the docs locally with make preview.
  2. Check poetry.lock dependencies are not updated.

@@ -11,7 +11,7 @@
.. hero-box::
:title: Welcome to ScyllaDB Documentation
:image: /_static/img/mascots-2/docs.svg
:button_icon: fa fa-arrow-right
:button_icon: icon-arrow-right
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: #19

Copy link
Collaborator

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annastuchlik annastuchlik merged commit 052a340 into main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants