Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion of error handling #3

Open
elfring opened this issue Mar 10, 2016 · 4 comments · May be fixed by #12
Open

Completion of error handling #3

elfring opened this issue Mar 10, 2016 · 4 comments · May be fixed by #12

Comments

@elfring
Copy link

elfring commented Mar 10, 2016

Would you like to add more error handling for return values from functions like the following?

@sdhand
Copy link
Owner

sdhand commented Mar 10, 2016

Thanks very much for pointing this out, will fix shortly.

@HalosGhost
Copy link
Contributor

Actually, a large number of functions used are capable of failing, and there is little code in-place to handle it. I'll be more than happy to help you out with this if you would like.

@HalosGhost HalosGhost linked a pull request Apr 17, 2016 that will close this issue
@halfwit
Copy link

halfwit commented Apr 23, 2016

@sdhand, there are two distinct types of calls that we can make for any server request - in general a checked and unchecked type. https://xcb.freedesktop.org/manual/structxcb__generic__error__t.html and, it seems that we aren't doing very much on the event loop. So, I'm wondering if you would prefer we swap over to all of our calls being checked calls, so that we can immediately handle errors should they arise with the use of a follow up call - or if you'd like to just use a pass/fail approach to a call and lose the ability to narrow down errors?

@halfwit
Copy link

halfwit commented Apr 24, 2016

Save for event, naturally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants