Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: what is the recommended process for renaming a package #699

Open
ezzarghili opened this issue Jun 28, 2024 · 3 comments
Open

Question: what is the recommended process for renaming a package #699

ezzarghili opened this issue Jun 28, 2024 · 3 comments

Comments

@ezzarghili
Copy link
Contributor

Hello,

The GCN (Graal Cloud Native) project and its tools are being renamed to GDK (Graal Dev Kit).

This has been already reflected on the website and repo, artifacts update is scheduld for next release on July 16th 2024 .

I was wondering what would be the best way to approch this in SDKMAN?

  • Rename the existing package from GCN to GDK?
  • Create a PR for a new GDK package, how do we archive the old version (mark it as moved?)

Thanks

@ezzarghili ezzarghili changed the title Question: what is the recommend process for renaming a package Question: what is the recommended process for renaming a package Jun 28, 2024
@marc0der
Copy link
Member

marc0der commented Jul 1, 2024

Hi @ezzarghili 👋

I'm a bit confused about this. We currently host two variants of GraalVM, namely the Oracle packages (identified by graal on the CLI) and the Community Edition (identified by graalce).

Rename the existing package from GCN to GDK?

Not sure what that means. Is that on the SDKMAN website or somewhere else? We have nothing called GCN right now.

Create a PR for a new GDK package, how do we archive the old version (mark it as moved?)

The entire project is driven by dynamic data. If you are referring to the individual versions that we host, they are all in a database. Renaming these historic versions would require a data migration on our side. Also, we point to the actual binaries on the Internet, so I hope that you are not proposing renaming the actual web resources, as that would cause widespread breakage.

@ezzarghili
Copy link
Contributor Author

ezzarghili commented Jul 5, 2024

Hi @marc0der
Applogies if my initial post was not clear enough, I am talking about the tool defined in GCN not GraalVM.

We would want to only rename the package and new versions

Thank you for continous assistance

@marc0der
Copy link
Member

Hi @ezzarghili, no apologies from me for not fully understanding the context!

We don't currently have a process for renaming a candidate, so I might need to do this manually against our database using some scripts. Also, are you currently publishing your releases using our vendor API? If so, that would also need some changes. Lastly, can you send me how the new copy should read on our website?

Once I have all these bits, I can look into doing it all in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants