remove droping Error column

sdv-dev · Oct 31, 2023 · 9718600 · 9718600
1 parent c237226
commit 9718600
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/sdmetrics/reports/multi_table/_properties/cardinality.py b/sdmetrics/reports/multi_table/_properties/cardinality.py
@@ -67,9 +67,6 @@ def _generate_details(self, real_data, synthetic_data, metadata, progress_bar=No
             'Error': error_messages,
         })
 
-        if self.details['Error'].isna().all():
-            self.details = self.details.drop('Error', axis=1)
-
     def _get_table_relationships_plot(self, table_name):
         """Get the table relationships plot from the parent child relationship scores for a table.
 

diff --git a/sdmetrics/reports/multi_table/_properties/relationship_validity.py b/sdmetrics/reports/multi_table/_properties/relationship_validity.py
@@ -75,9 +75,6 @@ def _generate_details(self, real_data, synthetic_data, metadata, progress_bar=No
             'Error': error_messages,
         })
 
-        if self.details['Error'].isna().all():
-            self.details = self.details.drop('Error', axis=1)
-
     def _get_table_relationships_plot(self, table_name):
         """Get the table relationships plot from the parent child relationship scores for a table.