From b0cc02093b18403e79e026733b5d775267698eb5 Mon Sep 17 00:00:00 2001 From: R-Palazzo Date: Tue, 31 Oct 2023 14:02:52 -0600 Subject: [PATCH] remove droping Error column --- sdmetrics/reports/multi_table/_properties/__init__.py | 2 +- sdmetrics/reports/multi_table/_properties/cardinality.py | 3 --- .../reports/multi_table/_properties/relationship_validity.py | 3 --- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/sdmetrics/reports/multi_table/_properties/__init__.py b/sdmetrics/reports/multi_table/_properties/__init__.py index 60eea9d0..b40bd18a 100644 --- a/sdmetrics/reports/multi_table/_properties/__init__.py +++ b/sdmetrics/reports/multi_table/_properties/__init__.py @@ -7,9 +7,9 @@ from sdmetrics.reports.multi_table._properties.column_shapes import ColumnShapes from sdmetrics.reports.multi_table._properties.coverage import Coverage from sdmetrics.reports.multi_table._properties.inter_table_trends import InterTableTrends +from sdmetrics.reports.multi_table._properties.relationship_validity import RelationshipValidity from sdmetrics.reports.multi_table._properties.structure import Structure from sdmetrics.reports.multi_table._properties.synthesis import Synthesis -from sdmetrics.reports.multi_table._properties.relationship_validity import RelationshipValidity __all__ = [ 'BaseMultiTableProperty', diff --git a/sdmetrics/reports/multi_table/_properties/cardinality.py b/sdmetrics/reports/multi_table/_properties/cardinality.py index ca683844..f616ff4b 100644 --- a/sdmetrics/reports/multi_table/_properties/cardinality.py +++ b/sdmetrics/reports/multi_table/_properties/cardinality.py @@ -67,9 +67,6 @@ def _generate_details(self, real_data, synthetic_data, metadata, progress_bar=No 'Error': error_messages, }) - if self.details['Error'].isna().all(): - self.details = self.details.drop('Error', axis=1) - def _get_table_relationships_plot(self, table_name): """Get the table relationships plot from the parent child relationship scores for a table. diff --git a/sdmetrics/reports/multi_table/_properties/relationship_validity.py b/sdmetrics/reports/multi_table/_properties/relationship_validity.py index 7eff5d16..c85a957b 100644 --- a/sdmetrics/reports/multi_table/_properties/relationship_validity.py +++ b/sdmetrics/reports/multi_table/_properties/relationship_validity.py @@ -75,9 +75,6 @@ def _generate_details(self, real_data, synthetic_data, metadata, progress_bar=No 'Error': error_messages, }) - if self.details['Error'].isna().all(): - self.details = self.details.drop('Error', axis=1) - def _get_table_relationships_plot(self, table_name): """Get the table relationships plot from the parent child relationship scores for a table.