Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to strict VAT ID validation check #133

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zurabarata
Copy link

@zurabarata zurabarata commented Dec 29, 2022

add option to do strict VAT validation check:

  • allow the user to choose between clean & dirty when checking the vatId
  • set shouldRemoveExtraChars default value to true in order to avoid breaking changes

fixes issue Nr. 123

@zurabarata
Copy link
Author

hey @se-panfilov,
it would be great if you find some time to review this one ☝️

@zurabarata zurabarata changed the title Add option to do strict VAT validation check Add option to strict VAT ID validation check Jan 19, 2023
@mattickx
Copy link

Since this repo seemed so abandoned I've created a fork on:
https://github.com/mathieumagalhaes/jsvat-next

I like this change, but I was wondering if it would be possible to create an 'options' objects to pass, instead of adding variables. Which would make it more extendible in the future.
Feel free to add the changes to the forked repo.
Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants